Improve Normalize Whitespace for block lambdas #46661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
requested changes
Aug 10, 2020
| @@ -282,7 +282,8 @@ private static int LineBreaksAfterOpenBrace(SyntaxToken currentToken, SyntaxToke | |||
| private static int LineBreaksAfterCloseBrace(SyntaxToken currentToken, SyntaxToken nextToken) | |||
| { | |||
| if (currentToken.Parent is InitializerExpressionSyntax || | |||
| currentToken.Parent.IsKind(SyntaxKind.Interpolation)) | |||
| currentToken.Parent.IsKind(SyntaxKind.Interpolation) || | |||
| currentToken.Parent?.Parent is ParenthesizedLambdaExpressionSyntax or SimpleLambdaExpressionSyntax) | |||
There was a problem hiding this comment.
What about anonymous methods?
Also, can just do is LambdaExpression
| }; | ||
| } | ||
| });"); | ||
| } |
There was a problem hiding this comment.
Would prefer a theory here. That way if one fails it's trivial to just run that config
YairHalberstadt
requested review from
CyrusNajmabadi
and removed request for
a team
CyrusNajmabadi
approved these changes
Aug 10, 2020
333fred
approved these changes
Aug 12, 2020
333fred
added
Area-Compilers
Community
|
@dotnet/roslyn-compiler for a second review. |
ghost
added this to the 
|
Merged/squashed. Thanks @YairHalberstadt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46656