-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put generated files to disk: #47047
Merged
+529
−50
Merged
Put generated files to disk: #47047
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8030d85
Put generated files to disk:
chsienki 2113030
Use ToList not ToImmutableArray
chsienki f0b7046
fixup
chsienki c56d54b
PR Feedback:
chsienki a6f157a
PR Feedback
chsienki beac3e4
Fix tests
chsienki 31f5482
Use short type name:
chsienki d3f3342
Fix IDE test
chsienki b5524c1
Update IDE generated source manager to understand new format
chsienki 31407af
Fixup resources post merge
chsienki 284c5d5
Persisit the encoding to disk to ensure PDB and source file match
chsienki bbc51cc
PR feedback
chsienki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use ToList not ToImmutableArray
commit 2113030733ac9ea42e3f1b53f4c2e74ba7951729
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no surprises here about other things adding trees? Nothing funky on the VB side of things around My since I think that implicitly adds trees, but probably not to the arguments compilation's SyntaxTrees collection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing funky for C#. VB and My trees is a good thought, but the generators wont get loaded in that case, so this code will never execute.