Fix CodeLens data point invalidation #47138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
codelens-invalidate
branch
from
205bda0
to
ee6d7ae
Compare
sharwell
commented
Aug 26, 2020
sharwell
commented
Aug 26, 2020
| { | ||
| var documentId = document.Id; | ||
| return new List<Guid>(2) { documentId.ProjectId.Id, documentId.Id }; | ||
| var projectVersion = await project.GetDependentVersionAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
❔ How expensive is GetDependentVersionsAsync?
- Do we need to implement a
WorkspaceChangedthrottle here, or just make the calls to get the version? - Do we need to add an argument to only get the versions for projects we currently have data points for?
sharwell
force-pushed
the
codelens-invalidate
branch
from
ee6d7ae
to
3b0d93d
Compare
ryzngard
reviewed
Aug 27, 2020
| { | ||
| lock (_dataPoints) | ||
| { | ||
| if (_dataPoints.TryGetValue(dataPoint.Descriptor.ProjectGuid, out var points) |
There was a problem hiding this comment.
When do we expect _dataPoints.TryGetValue or the Remove(dataPoint) to return false here?
There was a problem hiding this comment.
I would not expect that.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.