Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary initialize request to liveshare server from livesh… #47199

Merged
1 commit merged into from
Aug 28, 2020

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 27, 2020

…are client

These were previously used for the classifications experiment, but that code no longer exists. We no longer need to retrieve these again (liveshare already initializes once).

Since this is hanging we should just remove it.

fixes #AB1174053

@dibarbet dibarbet added Bug Area-IDE LSP issues related to the roslyn language server protocol implementation labels Aug 27, 2020
@dibarbet dibarbet requested a review from a team as a code owner August 27, 2020 20:10
@ghost
Copy link

ghost commented Aug 27, 2020

Hello @dibarbet!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 2e3e714 into dotnet:master Aug 28, 2020
@ghost ghost added this to the Next milestone Aug 28, 2020
@allisonchou allisonchou modified the milestones: Next, 16.8.P3 Aug 31, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE auto-merge Bug LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants