Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and un-skip PropertySubPatternCompletionProviderTests and GenerateVariableTests #47417

Merged
merged 5 commits into from
Sep 5, 2020
Merged

Fix and un-skip PropertySubPatternCompletionProviderTests and GenerateVariableTests #47417

merged 5 commits into from
Sep 5, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 3, 2020 •
edited
Loading

Fixes #30794

@Youssef1313 Youssef1313 requested a review from a team as a code owner September 3, 2020 11:55
@Youssef1313 Youssef1313 marked this pull request as draft September 3, 2020 11:55
@Youssef1313 Youssef1313 changed the title Draft Fix and un-skip pattern matching completion tests Sep 3, 2020
@Youssef1313 Youssef1313 marked this pull request as ready for review September 3, 2020 16:27
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. labels Sep 3, 2020
@Youssef1313
Copy link
Member Author

Youssef1313 commented Sep 3, 2020 •
edited
Loading

"PR For Personal Review Only" label was probably unintentional (or probably because I had forgotten to update the PR description)?

@Youssef1313 Youssef1313 changed the title Fix and un-skip pattern matching completion tests Fix and un-skip PropertySubPatternCompletionProviderTests and GenerateVariableTests Sep 3, 2020
@Youssef1313
Copy link
Member Author

Pinging @CyrusNajmabadi for review.

CyrusNajmabadi
CyrusNajmabadi approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 8c2c2e9 into dotnet:master Sep 5, 2020
@ghost ghost added this to the Next milestone Sep 5, 2020
@Youssef1313 Youssef1313 deleted the patch-27 branch September 5, 2020 22:00
@dibarbet dibarbet modified the milestones: Next, 16.8.P4 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it.
Projects
None yet
Milestone
16.8.P4
Development

Successfully merging this pull request may close these issues.

Tests in PropertySubpatternCompletionProviderTests fail when LanguageVersion != 8.0
4 participants
@Youssef1313 @CyrusNajmabadi @dibarbet @jinujoseph