Use MessagePack for serialization, move services to IServiceBroker #47461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any info on perf? |
|
Will see once I can merge all the PRs and use it for EnC. |
...sualStudio/Core/Def/Implementation/DesignerAttribute/VisualStudioDesignerAttributeService.cs
Outdated
Show resolved
Hide resolved
...Implementation/SemanticClassificationCache/VisualStudioSemanticClassificationCacheService.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TodoComments/VisualStudioTodoCommentsService.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TodoComments/VisualStudioTodoCommentsService.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Test.Next/Services/ServiceHubServicesTests.cs
Outdated
Show resolved
Hide resolved
tmat
force-pushed
the
MessagePack
branch
9 times, most recently
from
f3a9083
to
cd4e67b
Compare
tmat
changed the title
|
@dotnet/roslyn-compiler For review of adding DataContract attributes to a couple of types in the compiler layer. |
tmat
force-pushed
the
MessagePack
branch
2 times, most recently
from
ae07d77
to
bcb3991
Compare
ghost
added this to the 
sharwell
reviewed
Sep 19, 2020
sharwell
reviewed
Sep 19, 2020
sharwell
reviewed
Sep 19, 2020
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/SymbolUsageInfo.cs
Show resolved
Hide resolved
sharwell
reviewed
Sep 19, 2020
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Oct 1, 2020
This reverts commit 4123b1c. Revert "Do not cancel operations after point of no return" This reverts commit 57759e3. Revert "Remove ClientDisconnectedSource" This reverts commit 24bcf13. Revert "Wait for GetAssetsAsync before returning" This reverts commit c020fe8. Revert "Make sure to complete copy before returning" This reverts commit ebb674f. Revert "Prevent potential deadlocks when reading/writing assets (dotnet#47864)" This reverts commit f60ff7e. Revert "Ensure IServiceBroker is used on a background thread" This reverts commit 1f7397e. Revert "Provide required callback targets" This reverts commit e0e3655. Revert "Ensure IServiceBroker is used on a background thread" This reverts commit 42202d8. Revert "Use MessagePack for serialization, move services to IServiceBroker (dotnet#47461)" This reverts commit e91ccb5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch all IServiceBroker services to MessagePack serialization instead of using Newtonsoft.JSON.
Annotate types that are serialized when communicating with ServiceHub services with DataContract attributes.
Migrate more Roslyn services to IServiceBroker.
Recommended review strategy is commit by commit.
Fixes #47538.
Fixes #47720.
Fixes #43855.
Pre-req for #40476.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1165101.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1179103.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1109488.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1106865.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1133277.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1121323.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1121321.
Follow up: dotnet/runtime#42412