Use static lambdas to better express intent concisely #47468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Sep 4, 2020
| @@ -64,10 +64,9 @@ public Accessor(SQLitePersistentStorage storage) | |||
|
|
|||
| [PerformanceSensitive("https://github.com/dotnet/roslyn/issues/36114", AllowCaptures = false)] | |||
There was a problem hiding this comment.
would be nifty if something validated this automatically. for now though, we have the attribute declaring intent, and we can ensure it is followed by use of static lambdas.
There was a problem hiding this comment.
That's the plan for PerfSensitiveAnalyzer, we just never get time to work on that
sharwell
approved these changes
Sep 4, 2020
genlu
approved these changes
Sep 4, 2020
|
Hello @CyrusNajmabadi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of areas where we switched, in the past, from a normal lambda to a static delegate to ensure we didn't accidentally capture something. The original changes were done because the captures ended up causing perf issues, and we wanted to make sure we didn't accidentally regress this.
We can now state this simply in the source by explicitly using a static-lambda. These lambdas now convey explicitly that they shoudl not capture, and it's no longer possible to accidentally cause them to do so (without a very obvious textual change on the declaration).