Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse byte arrays for common attribute signatures #47502

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Reuse byte arrays for common attribute signatures #47502

merged 1 commit into from
Sep 9, 2020

Conversation

cston
Copy link
Member

@cston cston commented Sep 6, 2020

No description provided.

@cston cston requested a review from a team as a code owner September 6, 2020 19:46
@CyrusNajmabadi
Copy link
Member

@cston would this be a good candidate for source generation?

@cston cston closed this Sep 7, 2020
@cston cston reopened this Sep 7, 2020
@cston
Copy link
Member Author

cston commented Sep 7, 2020 •
edited
Loading

would this be a good candidate for source generation?

Perhaps, although the current format is already easy to maintain, and changes are usually minor and incremental.

jcouv
jcouv approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@cston cston requested a review from a team September 8, 2020 18:28
@jcouv jcouv self-assigned this Sep 8, 2020
@cston cston merged commit 00edbce into dotnet:master Sep 9, 2020
@ghost ghost added this to the Next milestone Sep 9, 2020
@cston cston deleted the signatures branch September 9, 2020 22:00
@dibarbet dibarbet modified the milestones: Next, 16.8.P4 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
16.8.P4
Development

Successfully merging this pull request may close these issues.
5 participants
@cston @CyrusNajmabadi @333fred @jcouv @dibarbet