Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show events completion inside NameOf #47686

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Show events completion inside NameOf #47686

merged 2 commits into from
Sep 15, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 14, 2020 •
edited
Loading

Fixes #46472

@Youssef1313 Youssef1313 changed the title Add failing test for #46472 Draft Sep 14, 2020
@Youssef1313 Youssef1313 changed the title Draft Show events completion inside NameOf Sep 15, 2020
@Youssef1313 Youssef1313 marked this pull request as ready for review September 15, 2020 12:17
@Youssef1313 Youssef1313 requested a review from a team as a code owner September 15, 2020 12:17
Youssef1313
Youssef1313 commented Sep 15, 2020
View reviewed changes
src/Workspaces/VisualBasic/Portable/Recommendations/VisualBasicRecommendationServiceRunner.vb
Private Shared Function FilterEventsAndGeneratedSymbols(node As MemberAccessExpressionSyntax, s As ISymbol) As Boolean
If s.Kind = SymbolKind.Event Then
Private Function FilterEventsAndGeneratedSymbols(node As MemberAccessExpressionSyntax, s As ISymbol) As Boolean
If s.Kind = SymbolKind.Event AndAlso Not _context.IsNameOfContext Then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was very specific here to the linked issue and allowed extended events to only NameOf.

Are there any other places where events should show in completion but they currently don't?

@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Language-VB labels Sep 15, 2020
@CyrusNajmabadi
Copy link
Member

LGTM. please let me know when this passes.

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi The build passed.

@CyrusNajmabadi
Copy link
Member

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 2f9b858 into dotnet:master Sep 15, 2020
@ghost ghost added this to the Next milestone Sep 15, 2020
@Youssef1313 Youssef1313 deleted the patch-7 branch September 15, 2020 22:50
@dibarbet dibarbet modified the milestones: Next, 16.8.P4 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Language-VB
Projects
None yet
Milestone
16.8.P4
Development

Successfully merging this pull request may close these issues.

VB.NET: IntelliSense doesn't show Events when using NameOf
4 participants
@Youssef1313 @CyrusNajmabadi @dibarbet @jinujoseph