Wait for async operation to complete before disposing workspace #47993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not actually certain how this impacts things. if this has a change in behavior, we should likely disseminate this info so people don't use the previous form in new PRs. |
|
@CyrusNajmabadi Here's the analyzer request for this well-known bug scenario: dotnet/roslyn-analyzers#3071 |
davidwengier
approved these changes
Sep 23, 2020
|
oh boy. yeah, that's bad. there was a discussion at some point about really pushing people to always await, just to avoid these scenarios. given that we hit this ourselves, i'm now much more inclined to accept such a rule. |
CyrusNajmabadi
approved these changes
Sep 23, 2020
AArnott
approved these changes
Sep 24, 2020
|
I've been bit by this bug a few times too. I even call it out in our existing analyzer proposal. microsoft/vs-threading#518 |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.