Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused private method #48098

Closed
wants to merge 1 commit into from
Closed

Delete unused private method #48098

wants to merge 1 commit into from

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313 Youssef1313 marked this pull request as ready for review September 29, 2020 20:57
@Youssef1313 Youssef1313 requested a review from a team as a code owner September 29, 2020 20:57
@Youssef1313 Youssef1313 changed the title Draft: Delete unused private method Delete unused private method Sep 29, 2020
@Youssef1313
Copy link
Member Author

@sharwell Could you give a look?

@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Sep 30, 2020
@sharwell
Copy link
Member

sharwell commented Nov 5, 2020

Likely an oversight from the initial implementation. If we do add it in the future, it would be part of a separate design implementation.

@Youssef1313
Copy link
Member Author

@sharwell Should this be ready for merge?

@sharwell
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Base automatically changed from master to main March 3, 2021 23:52
@Youssef1313 Youssef1313 mentioned this pull request Apr 7, 2021
Merged
@Youssef1313
Copy link
Member Author

Closing since this is being done as part of #52464 (commit 9802119)

@Youssef1313 Youssef1313 closed this Apr 8, 2021
@Youssef1313 Youssef1313 deleted the patch-31 branch April 8, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@sharwell sharwell Awaiting requested review from sharwell

Assignees

@sharwell sharwell

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssef1313 @sharwell @CyrusNajmabadi @jinujoseph