Correct IsImplicitlyDeclared for SimpleProgramNamedTypeSymbol

[Youssef1313]

The class documentation clearly states:

    /// <summary>
    /// Represents implicitly declared type for a Simple Program feature.
    /// </summary>

Fixes #48171

[CyrusNajmabadi]

Needs tests :)

[AlekseyTs]

public override bool IsImplicitlyDeclared => true; [](start = 8, length = 50)

This is not a change that we would like to make. Please revert

[AlekseyTs]

This isn't a change that we would want to make.

[AlekseyTs]

@Youssef1313 In the future, especially for bugs that require changes in compilers, please make sure that:

• the problem in the bug has been stated in compiler terms (i.e. some API returns unexpected value, etc)
• the bug has been triaged and that we confirmed that we would like to make the suggested change

[Youssef1313]

This isn't a change that we would want to make.

Can you clarify why?

I can't see why the change is wrong. The documentation for IsImplicitlyDeclared states:

Returns true if this symbol was automatically created by the compiler, and does not have an explicit corresponding source code declaration.

And that's the case with the symbol <Program>$ (i.e. SimpleProgramNamedTypeSymbol). It is automatically created by the compiler and it's indeed doesn't have an explicit source code declaration.