Update IsImplicitlyDeclared doc #48199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Sep 30, 2020
| @@ -127,7 +127,7 @@ public interface ISymbol : IEquatable<ISymbol?> | |||
|
|
|||
| /// <summary> | |||
| /// Returns true if this symbol was automatically created by the compiler, and does not have | |||
| /// an explicit corresponding source code declaration. | |||
| /// an explicit corresponding source code declaration. This doesn't include the generated method and class for top-level statements. | |||
There was a problem hiding this comment.
I think the key point is that these are not generated methods. A generated method and class is something like PrivateImplementationDetails. The top-level <Program>$ and <Main>$ are created because of a specific user action: writing a top-level main. That means create these things. It's not implicitly created.
If we need to add a note, I'd prefer it go down in the remarks below.
333fred
added
Area-Compilers
Community
333fred
reviewed
Sep 30, 2020
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
333fred
approved these changes
Sep 30, 2020
ghost
added this to the 
|
@Youssef1313 Thanks for the contribution. |
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48193