Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log telemetry item when parse or compilation options change #48215

Merged
merged 9 commits into from
Nov 1, 2020
Merged

Log telemetry item when parse or compilation options change #48215

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2245fb2
Log telemetry item when parse or compilation options change
davidwengier Oct 1, 2020
68c3bcb
Merge branch 'master' into CompilationThrownAwayTelemetry
davidwengier Oct 1, 2020
0c5b380
Move logging code to proejct
davidwengier Oct 12, 2020
bb1d44a
Log when changing assembly name
davidwengier Oct 12, 2020
09e2c18
Update src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualS…
davidwengier Oct 26, 2020
3b9db66
Update src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualS…
davidwengier Oct 27, 2020
7c9d02a
Check for an active session before logging
Oct 27, 2020
dfc0cf8
Make service optional
davidwengier Oct 27, 2020
f8438ed
Check if the solution is fully loaded, and don't log telemetry if not.
davidwengier Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
using Microsoft.CodeAnalysis.Host.Mef;
using Microsoft.CodeAnalysis.Internal.Log;
using Microsoft.CodeAnalysis.Shared.Extensions;
using Microsoft.CodeAnalysis.Telemetry;
using Microsoft.CodeAnalysis.Text;
using Microsoft.VisualStudio.LanguageServices.Implementation.TaskList;
using Roslyn.Utilities;
Expand All @@ -27,6 +28,7 @@ internal sealed class VisualStudioProject

private readonly VisualStudioWorkspaceImpl _workspace;
private readonly HostDiagnosticUpdateSource _hostDiagnosticUpdateSource;
private readonly IWorkspaceTelemetryService _telemetryService;

/// <summary>
/// Provides dynamic source files for files added through <see cref="AddDynamicSourceFile" />.
Expand Down Expand Up @@ -138,6 +140,8 @@ internal VisualStudioProject(
_dynamicFileInfoProviders = dynamicFileInfoProviders;
_hostDiagnosticUpdateSource = hostDiagnosticUpdateSource;

_telemetryService = _workspace.Services.GetRequiredService<IWorkspaceTelemetryService>();
davidwengier marked this conversation as resolved.
Show resolved Hide resolved

Id = id;
Language = language;
_displayName = displayName;
Expand Down Expand Up @@ -195,7 +199,7 @@ private void ChangeProjectProperty<T>(ref T field, T newValue, Func<Solution, So

field = newValue;

if (logThrowAwayTelemetry)
if (logThrowAwayTelemetry && _telemetryService.HasActiveSession)
{
TryReportCompilationThrownAway(_workspace.CurrentSolution.State, Id);
}
Expand Down