Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSharpConvertAutoPropertyToFullProperty... handles init accessor #48231

Merged
merged 2 commits into from
Oct 2, 2020
Merged

CSharpConvertAutoPropertyToFullProperty... handles init accessor #48231

merged 2 commits into from
Oct 2, 2020

Conversation

louis-z
Copy link
Contributor

@louis-z louis-z commented Oct 2, 2020

Fixes #48133

@louis-z louis-z requested a review from a team as a code owner October 2, 2020 00:17
@louis-z
Copy link
Contributor Author

louis-z commented Oct 2, 2020

I hope I'm not being overly simplistic here, but

  • the fix appears to be 1 line of code, and
  • I only modified a single test, to validate that the code fixer behaves the same way whether dealing with set or init

LMK if I should do more.

@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Oct 2, 2020 •
edited
Loading

'm not being overly simplistic here, but

Nope! this looks just right to me :) Thanks!

@louis-z @CyrusNajmabadi
Update src/EditorFeatures/CSharpTest/ConvertAutoPropertyToFullPropert…
ae519a8 
…y/ConvertAutoPropertyToFullPropertyTests.cs

Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
@CyrusNajmabadi
Copy link
Member

Thanks for the contribution!

@CyrusNajmabadi CyrusNajmabadi merged commit e4c91a3 into dotnet:master Oct 2, 2020
@ghost ghost added this to the Next milestone Oct 2, 2020
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 3, 2020
@louis-z louis-z deleted the issue-48133 branch October 4, 2020 17:41
@louis-z louis-z mentioned this pull request Oct 9, 2020
Closed
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.

Support init accessors in CSharpConvertAutoPropertyToFullPropertyCodeRefactoringProvider
4 participants
@louis-z @CyrusNajmabadi @jinujoseph @Cosifne