Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle checked and unchecked statements in formatting #48242

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Handle checked and unchecked statements in formatting #48242

merged 2 commits into from
Oct 2, 2020

Conversation

Youssef1313
Copy link
Member

No description provided.

This was referenced Oct 2, 2020
Closed
Closed
@Youssef1313 Youssef1313 marked this pull request as ready for review October 2, 2020 15:53
@Youssef1313 Youssef1313 requested a review from a team as a code owner October 2, 2020 15:53
@Youssef1313 Youssef1313 changed the title Add formatting tests with checked and unchecked Handle checked and unchecked statements in formatting Oct 2, 2020
@CyrusNajmabadi
Copy link
Member

Does this fix a partiular issue? what's hte behavior without the fix? thanks!

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi Before the fix, the block won't be formatted correctly on writing }. I confirmed that the test fails before the fix.

@CyrusNajmabadi
Copy link
Member

SGTM. thanks :)

@CyrusNajmabadi CyrusNajmabadi merged commit 8011bb3 into dotnet:master Oct 2, 2020
@ghost ghost added this to the Next milestone Oct 2, 2020
@Youssef1313 Youssef1313 deleted the patch-41 branch October 2, 2020 19:36
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 3, 2020
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssef1313 @CyrusNajmabadi @jinujoseph @Cosifne