Increase CoreCLR dump information #49790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets environment variables that will help make the dumps for a CLR bug more actionable by the runtime team. dotnet/runtime#45557
|
@tmat, @dotnet/roslyn-infrastructure PTAL This is to help the runtime team track down the cause of dotnet/runtime#45557 |
JoeRobich
approved these changes
Dec 4, 2020
ghost
merged commit 
ghost
added this to the 
| #if NETCOREAPP | ||
| // These environment variables will generate better dump information for the runtime team | ||
| // that will help them track down a GC issue that is impacting ConcurrentDictionary | ||
| // https://github.com/dotnet/runtime/issues/45557 |
There was a problem hiding this comment.
Thanks for linking to the bug!
RikkiGibson
reviewed
Dec 4, 2020
|
|
||
| void MaybeAddStressEnvironmentVariables() | ||
| { | ||
| #if NETCOREAPP |
There was a problem hiding this comment.
It just occurred to me that RunTests.dll itself always defines this symbol even if we are running net472 tests. May be more appropriate to check for the absence of "net472" in Options.TargetFrameworks
There was a problem hiding this comment.
Doh! You're right I missed that. I will get that fixed up in a bit.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets environment variables that will help make the dumps for a CLR
bug more actionable by the runtime team.
dotnet/runtime#45557