Add a working internal progress system for codeactions #50243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jan 4, 2021
...torFeatures/Core.Wpf/Suggestions/SuggestedActions/UIThreadOperationContextProgressTracker.cs
Outdated
Show resolved
Hide resolved
…eadOperationContextProgressTracker.cs
|
Can you please attach a gif with the new user experience? |
mavasani
approved these changes
Jan 4, 2021
Added :) |
ghost
merged commit 
ghost
added this to the 
|
@CyrusNajmabadi As an FYI, this has reduced the UI delays on this path significantly. |
I'm reading that as a good thing. LMK if i'm misinterpreting and this is actually something to start an investigation over. :) |
|
Also, can you define 'significantly' here? A rough approximation will help. Thanks! |
|
Yes this is a good thing. Before this change, 1 in 4 (26%) times this path resulted in a user interrupted mouse/keyboard event. Now its 1 in 18 (5.6%). This has completely removed it from the top 500 delays. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal approach while we continue to iterate and refine: #50211
Looks like: