Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lower and upper bound inference in function pointer parameters #50249

Merged
merged 12 commits into from
Jan 28, 2021
Merged

Implement lower and upper bound inference in function pointer parameters #50249

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d2cfaf7
Implement lower and upper bound inference in function pointer parameters
333fred Jan 5, 2021
80ce5f8
Add addtional testing for pointer conversions. `T` cannot appear vari…
333fred Jan 7, 2021
d8afd5a
Skip unmanaged pointer peverify on framework.
333fred Jan 7, 2021
f656b06
PR feedback
333fred Jan 15, 2021
f91e8d8
Add missing parentheses.
333fred Jan 15, 2021
35ce5d0
Add more testing.
333fred Jan 15, 2021
56678c1
Ensure that exact inference checks calling convention and refkind equ…
333fred Jan 21, 2021
19b2492
Fix bug with parameter ref kind comparison, add test to cover.
333fred Jan 25, 2021
3175939
Fix potential null ref.
333fred Jan 25, 2021
532079e
Small formatting change for clarity.
333fred Jan 25, 2021
0bc2365
Check calling convention equality during type inference first phase i…
333fred Jan 25, 2021
415955d
Add more testing.
333fred Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/Conversions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ private static MethodGroupResolution ResolveDelegateOrFunctionPointerMethodGroup
if ((object)delegateInvokeMethodOpt != null)
{
var analyzedArguments = AnalyzedArguments.GetInstance();
GetDelegateArguments(source.Syntax, analyzedArguments, delegateInvokeMethodOpt.Parameters, binder.Compilation);
GetDelegateOrFunctionPointerArguments(source.Syntax, analyzedArguments, delegateInvokeMethodOpt.Parameters, binder.Compilation);
var resolution = binder.ResolveMethodGroup(source, analyzedArguments, useSiteDiagnostics: ref useSiteDiagnostics, inferWithDynamic: true,
isMethodGroupConversion: true, returnRefKind: delegateInvokeMethodOpt.RefKind, returnType: delegateInvokeMethodOpt.ReturnType,
isFunctionPointerResolution: isFunctionPointer, callingConventionInfo: callingConventionInfo);
Expand Down Expand Up @@ -229,7 +229,7 @@ public Conversion MethodGroupConversion(SyntaxNode syntax, MethodGroup methodGro

Debug.Assert((object)delegateInvokeMethod != null && !delegateInvokeMethod.HasUseSiteError,
"This method should only be called for valid delegate types");
GetDelegateArguments(syntax, analyzedArguments, delegateInvokeMethod.Parameters, Compilation);
GetDelegateOrFunctionPointerArguments(syntax, analyzedArguments, delegateInvokeMethod.Parameters, Compilation);
_binder.OverloadResolution.MethodInvocationOverloadResolution(
methods: methodGroup.Methods,
typeArguments: methodGroup.TypeArguments,
Expand All @@ -247,7 +247,7 @@ public Conversion MethodGroupConversion(SyntaxNode syntax, MethodGroup methodGro
return conversion;
}

public static void GetDelegateArguments(SyntaxNode syntax, AnalyzedArguments analyzedArguments, ImmutableArray<ParameterSymbol> delegateParameters, CSharpCompilation compilation)
public static void GetDelegateOrFunctionPointerArguments(SyntaxNode syntax, AnalyzedArguments analyzedArguments, ImmutableArray<ParameterSymbol> delegateParameters, CSharpCompilation compilation)
{
foreach (var p in delegateParameters)
{
Expand Down
Loading