Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to net5.0 reference assemblies #50486

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Conversation

jaredpar
Copy link
Member

This moves our tests to use the net5.0 reference assemblies.

This moves our tests to use the net5.0 reference assemblies.
@jaredpar jaredpar marked this pull request as ready for review January 21, 2021 16:23
@jaredpar jaredpar requested review from a team as code owners January 21, 2021 16:23
@jaredpar
Copy link
Member Author

@dotnet/roslyn-compiler PTAL

@@ -2079,7 +2079,7 @@ interface J { }

CheckEncLog(reader2,
Row(3, TableIndex.AssemblyRef, EditAndContinueOperation.Default),
Row(8, TableIndex.TypeRef, EditAndContinueOperation.Default),
Row(10, TableIndex.TypeRef, EditAndContinueOperation.Default),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmat wanted to make sure you saw this change. This change just moved from the netcoreapp3.1 to net5.0 reference assemblies. Unsure why this would cause the diff to change here. This is the only one that changed though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeRef is likely System.Action. Are we emitting now 2 more TypeRefs into each assembly?


In reply to: 562016108 [](ancestors = 562016108)

@@ -55052,7 +55068,7 @@ class C1 : I1, Interface<int>
";
foreach (var options in new[] { TestOptions.DebugDll, TestOptions.DebugWinMD })
{
var comp = CreateCompilationWithIL(source, ilSource, options: options, targetFramework: TargetFramework.NetCoreApp);
var comp = CreateCompilationWithIL(source, ilSource, options: options, targetFramework: TargetFramework.NetCoreApp, references: new[] { windowsRuntimeRef });;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;; [](start = 172, length = 2)

The correctness branch is complaining about a formatting issue. Probably this double semi-colon

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 5) modulo question on EnC test change for Tomas

@jcouv jcouv self-assigned this Jan 21, 2021
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaredpar jaredpar merged commit 3323bf3 into dotnet:master Jan 22, 2021
@ghost ghost added this to the Next milestone Jan 22, 2021
@jaredpar jaredpar deleted the ref2 branch January 22, 2021 16:41
@Cosifne Cosifne modified the milestones: Next, 16.9 Jan 27, 2021
@JoeRobich JoeRobich modified the milestones: 16.9, 16.9.P4 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants