-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to net5.0 reference assemblies #50486
Conversation
This moves our tests to use the net5.0 reference assemblies.
@dotnet/roslyn-compiler PTAL |
@@ -2079,7 +2079,7 @@ interface J { } | |||
|
|||
CheckEncLog(reader2, | |||
Row(3, TableIndex.AssemblyRef, EditAndContinueOperation.Default), | |||
Row(8, TableIndex.TypeRef, EditAndContinueOperation.Default), | |||
Row(10, TableIndex.TypeRef, EditAndContinueOperation.Default), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmat wanted to make sure you saw this change. This change just moved from the netcoreapp3.1 to net5.0 reference assemblies. Unsure why this would cause the diff to change here. This is the only one that changed though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TypeRef is likely System.Action. Are we emitting now 2 more TypeRefs into each assembly?
In reply to: 562016108 [](ancestors = 562016108)
@@ -55052,7 +55068,7 @@ class C1 : I1, Interface<int> | |||
"; | |||
foreach (var options in new[] { TestOptions.DebugDll, TestOptions.DebugWinMD }) | |||
{ | |||
var comp = CreateCompilationWithIL(source, ilSource, options: options, targetFramework: TargetFramework.NetCoreApp); | |||
var comp = CreateCompilationWithIL(source, ilSource, options: options, targetFramework: TargetFramework.NetCoreApp, references: new[] { windowsRuntimeRef });; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;; [](start = 172, length = 2)
The correctness branch is complaining about a formatting issue. Probably this double semi-colon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 5) modulo question on EnC test change for Tomas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moves our tests to use the net5.0 reference assemblies.