Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .NET SDK 5.0.102 #50692

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Move to .NET SDK 5.0.102 #50692

merged 1 commit into from
Jan 22, 2021

Conversation

jaredpar
Copy link
Member

The associated runtime version contains the fix for a CLR crash that we
are hitting in our infrastructure. Moving should help us increase
stability here.

dotnet/runtime#45557

@jaredpar jaredpar requested a review from a team as a code owner January 22, 2021 14:05
@jaredpar
Copy link
Member Author

@dotnet/roslyn-infrastructure PTAL

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 22, 2021

Dupe of #50675 (However, there are more changes in this PR than #50675)

The associated runtime version contains the fix for a CLR crash that we
are hitting in our infrastructure. Moving should help us increase
stability here.

dotnet/runtime#45557
@jaredpar
Copy link
Member Author

@Youssef1313 indeed it is a dupe. This is what I get for coding at 5AM 😦

@RikkiGibson your PR forgot the update to the installation docs. Fine with taking either PR but if we take yours we should include the doc update too.

@RikkiGibson
Copy link
Contributor

Is there some way to foolproof that in the future such as a comment in global.json as it's often not been done at the same time.

@sharwell
Copy link
Member

Is there some way to foolproof that in the future such as a comment in global.json as it's often not been done at the same time.

If the IDE/project system automatically downloaded the correct version, the comment wouldn't be required at all. The link only exists because the IDE support for global.json is incomplete.

@@ -20,7 +20,7 @@ The minimal required version of .NET Framework is 4.7.2.
- Ensure Visual Studio is on Version "16.8" or greater
- Ensure "Use previews of the .NET Core SDK" is checked in Tools -> Options -> Environment -> Preview Features
- Restart Visual Studio
1. [.NET Core SDK 5.0](https://dotnet.microsoft.com/download/dotnet-core/5.0) [Windows x64 installer](https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-5.0.100-windows-x64-installer)
1. [.NET Core SDK 5.0](https://dotnet.microsoft.com/download/dotnet-core/5.0) [Windows x64 installer](https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-5.0.102-windows-x64-installer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar change may be needed for the instructions on Unix

@jaredpar jaredpar merged commit 12172f8 into dotnet:master Jan 22, 2021
@ghost ghost added this to the Next milestone Jan 22, 2021
@jaredpar jaredpar deleted the netsdk branch January 22, 2021 16:43
@Cosifne Cosifne modified the milestones: Next, 16.9 Jan 27, 2021
@JoeRobich JoeRobich modified the milestones: 16.9, 16.9.P4 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants