Add UI for editorconfig files

[jmarolf]

This is the new UI that will appear when a developer opens an editorconfig file (note a user can still get to the old file view via "Open With..")

• fixes Ruleset editor equivalent for .editorconfig. #40365
• fixes EditorConfig user interface  #39414
• fixes C# Code Style - New .editorconfig option 'dotnet_style_prefer_simplified_interpolation' is not shown in UI. #42695

Feature walkthrough:

• Searching

• Filtering

• Sorting

• Saving

Formatting Tab

Code Style Tab

Analyzers Tab

TODO:

• Finish adding tests for editorconfig saving helpers
• Update Tools -> Options window to use new services
• Unify editorconfig saving types
• Remove/fix all //TODO(jmarolf) comments

[Youssef1313]

nit: typo

[mavasani]

@jmarolf Do you have UI screenshots?

[CyrusNajmabadi]

Pictures plz @jmarolf .

[CyrusNajmabadi]

Pictures plz @jmarolf .

[jmarolf]

@CyrusNajmabadi I pictured. Still working to update some things.

[jmarolf]

@CyrusNajmabadi would appreciate your opinion here. I believe I will be able to unify on IOption2 type for codestyle and whitespace settings so those additional types will likely go away soon, but are there any other concerns about the approach taken here?

[JohanLarsson]

One thing that would be useful is a checkbox for disabling all rules in a group. One use case is when disabling all StyleCop documentation rules in a test project.

[vatsalyaagrawal]

@jmarolf Yay!! Looking forward to shipping this. 🎉🎉

[jnm2]

One thing that would be useful is a checkbox for disabling all rules in a group. One use case is when disabling all StyleCop documentation rules in a test project.

I would expect it to be a single line disabling the category when possible, like with this StyleCop example.

[jmarolf]

@jnm2 got it: tracking here: #52388

[mavasani]

@jmarolf This file should not have been added. It duplicates a lot of functionality from ConfigurationUpdater used in Configure Severity lightbulb action, and leads to many inconsistencies between how editorconfig is updated under the covers from Editorconfig UX versus Configure Severity lightbulb action (#52720). Latter also handles updating category based severities, which I believe is a feature request for Editorconfig UX.

[jmarolf]

let me file a bug to explicitly track this. The intention was that I would send a cleanup PR to unify these implementations. As an aside: are there any tests for ConfigurationUpdater? I couldn't find any.

[jmarolf]

#52735

[Youssef1313]

@jmarolf Not directly tested, but the tests in here (VB) and here (C#) test it indirectly (they test the CodeFixProvider which depends on ConfigurationUpdater)

[jmarolf]

ah, thank you