Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOperation Test Porting Pt 3 #51206

Merged
merged 14 commits into from
Feb 25, 2021
Merged

IOperation Test Porting Pt 3 #51206

merged 14 commits into from
Feb 25, 2021

Commits on Feb 12, 2021

  1. Port: Ensure that attribute arguments are bound to their natural type… 

    … if they do not have one.

(cherry picked from commit 4af2613)
    @333fred
    333fred committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    c52f6e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Fixup: Simplify logic, ensure that builders aren't leaked and we aren… 

    …'t allocating arrays we don't need to.
    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1674c58 View commit details
    Browse the repository at this point in the history

  2. Port: Skip tests not compatible with IOperation 

    (cherry picked from commit d4ab21f)
    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    30a20db View commit details
    Browse the repository at this point in the history

  3. Port: Add test and verification condition for vb indexed properties. 

    (cherry picked from commit ff250a3)
    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b729808 View commit details
    Browse the repository at this point in the history

  4. Fixup: Tighten assertion on nested member initializers.

    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b74afde View commit details
    Browse the repository at this point in the history

  5. Add test for error case involving using declaration in a switch case.

    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    ab6dcf4 View commit details
    Browse the repository at this point in the history

  6. Add IOperation Test Hook helper

    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    df1c84a View commit details
    Browse the repository at this point in the history

  7. Adjust conditional access children for bad code.

    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e53af81 View commit details
    Browse the repository at this point in the history

  8. Remove incorrect assert.

    @333fred
    333fred committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    2d4a4b5 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Attribute binding changes: 

    * Simplify named argument binding by making all named args specifically BoundAssignmentOperators. They already were, this carries the knowledge through the rest of the code.
* Add tests for invalid attribute binding scenarios.
* Only bind constructor params for error recovery in bad cases.
* Use the correct binder when binding for error recover to avoid runaway binding.
    @333fred
    333fred committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    2cbe6de View commit details
    Browse the repository at this point in the history

  2. Fix iteration bug in conditional access, add test to demonstrate.

    @333fred
    333fred committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    49ed0a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Simplify constructor argument binding code by moving error binding cl… 

    …oser to overload resolution, remove unneeded frees.
    @333fred
    333fred committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    1955540 View commit details
    Browse the repository at this point in the history

  2. Remove SelectAsArrayInPlace as it no longer provides benefits.

    @333fred
    333fred committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    76e0ccd View commit details
    Browse the repository at this point in the history

  3. Minor formatting and comment change.

    @333fred
    333fred committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    c9fa820 View commit details
    Browse the repository at this point in the history