Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run server GC OOP with reduced process priority #51405

Merged
2 commits merged into from
Feb 23, 2021
Merged

Conversation

sharwell
Copy link
Member

No description provided.

@sharwell sharwell requested a review from a team as a code owner February 22, 2021 23:47
@CyrusNajmabadi
Copy link
Member

Def woudl like to take this. My understanding is that .Net themselves recommend being wary about server-gc as it can so effectively saturate the machine with work. We def want the benefits of the improvements there, but not at the expense of the host VS process. So this is a very easy way to get a best of both worlds outcome here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@jasonmalinowski
Copy link
Member

Can this cause issues where, when a GC isn't happening, we might have VS starving off the "background" work the user actually wanted?

@jasonmalinowski
Copy link
Member

(not opposing, but just wondering if this can have "interesting" side effects to be on the lookout for)

@sharwell
Copy link
Member Author

Can this cause issues where, when a GC isn't happening, we might have VS starving off the "background" work the user actually wanted?

I haven't seen this happen. What I've seen happen several times is OOP using CPU and causing severe delays in devenv.exe and/or VBCSCompiler.exe.

@ghost ghost merged commit 9556d05 into dotnet:master Feb 23, 2021
@ghost ghost added this to the Next milestone Feb 23, 2021
@sharwell sharwell deleted the oop-priority branch February 23, 2021 15:24
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants