-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run server GC OOP with reduced process priority #51405
Conversation
Def woudl like to take this. My understanding is that .Net themselves recommend being wary about server-gc as it can so effectively saturate the machine with work. We def want the benefits of the improvements there, but not at the expense of the host VS process. So this is a very easy way to get a best of both worlds outcome here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
Can this cause issues where, when a GC isn't happening, we might have VS starving off the "background" work the user actually wanted? |
(not opposing, but just wondering if this can have "interesting" side effects to be on the lookout for) |
src/Workspaces/Remote/ServiceHub/Services/Host/RemoteHostService.cs
Outdated
Show resolved
Hide resolved
I haven't seen this happen. What I've seen happen several times is OOP using CPU and causing severe delays in devenv.exe and/or VBCSCompiler.exe. |
No description provided.