Add support to lsif generation to generate for a single project #51458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
approved these changes
Mar 2, 2021
|
|
||
| private static async Task GenerateFromProjectAsync(FileInfo projectFile, ILsifJsonWriter lsifWriter, TextWriter logFile) | ||
| { | ||
| await LocateAndRegisterMSBuild(logFile); |
There was a problem hiding this comment.
Any reason not to just move the call to LocateAndRegisterMSBuild() into GenerateWithMSBuildLocatedAsync? Either merge the methods or just add it to the start of the other one, etc.
There was a problem hiding this comment.
Comments ont he method say:
// This method can't be loaded until we've registered MSBuild with MSBuildLocator, as otherwise
// we load ILogger prematurely which breaks MSBuildLocator.
[MethodImpl(MethodImplOptions.NoInlining)]
private static async Task GenerateWithMSBuildLocatedAsync(
FileInfo solutionOrProjectFile, ILsifJsonWriter lsifWriter, TextWriter logFile,
Func<MSBuildWorkspace, Task<Solution>> openAsync)
{
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.