Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete publishing step #51465

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Remove obsolete publishing step #51465

merged 1 commit into from
Mar 17, 2021

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 25, 2021

This was only needed for legacy Maestro publishing.

@tmat
Copy link
Member Author

tmat commented Feb 25, 2021

@jaredpar @RikkiGibson

@JoeRobich
Copy link
Member

JoeRobich commented Feb 25, 2021

With this change do we need to maintain the channel information in the PublishData.json?

@tmat
Copy link
Member Author

tmat commented Feb 25, 2021

Good point. Will remove them.

@RikkiGibson
Copy link
Contributor

Is there anything we should do to test this before merging?

Base automatically changed from master to main March 3, 2021 23:53
@JoeRobich
Copy link
Member

@tmat @RikkiGibson Opened #51918 to remove channel publishing data.

@tmat
Copy link
Member Author

tmat commented Mar 17, 2021

@JoeRobich Is it ok to merge this then?

@JoeRobich
Copy link
Member

@tmat Let's merge it!

@tmat tmat merged commit b44e79e into dotnet:main Mar 17, 2021
@ghost ghost added this to the Next milestone Mar 17, 2021
@tmat tmat deleted the PublishingCleanup branch March 17, 2021 20:57
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants