Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'AddImportsAnnotation' #51469

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Add 'AddImportsAnnotation' #51469

merged 1 commit into from
Feb 25, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 25, 2021 •
edited
Loading

Fixes #51354

NOTE: Tests that contains compile errors after fix weren't affected. (i.e, they still have fully qualified return type). I believe the new testing library wouldn't have allowed such tests.

@Youssef1313 Youssef1313 marked this pull request as ready for review February 25, 2021 09:57
@Youssef1313 Youssef1313 requested a review from a team as a code owner February 25, 2021 09:57
@Youssef1313 Youssef1313 mentioned this pull request Feb 25, 2021
Open
sharwell
sharwell approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the new testing library wouldn't have allowed such tests.

It allows them, but requires the compiler errors be explicitly declared.

@CyrusNajmabadi CyrusNajmabadi merged commit 3729917 into dotnet:master Feb 25, 2021
@ghost ghost added this to the Next milestone Feb 25, 2021
@CyrusNajmabadi
Copy link
Member

Thanks!

@Youssef1313 Youssef1313 deleted the patch-4 branch February 25, 2021 19:45
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
16.10.P2
Development

Successfully merging this pull request may close these issues.

Automatically add the usings for System.Threading.Tasks in the "Make method async refactoring"
4 participants
@Youssef1313 @CyrusNajmabadi @sharwell @allisonchou