Fix nullable annotations #51522
Merged
Fix nullable annotations #51522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 336036ee4dc30484c54fd345314fd10d2e3d1f06)
333fred
commented
Feb 26, 2021
| @@ -96,7 +96,7 @@ private set | |||
| internal BoundExpression MakeInvocationExpression( | |||
| BinderFlags flags, | |||
| SyntaxNode node, | |||
| BoundExpression? receiver, | |||
| BoundExpression receiver, | |||
There was a problem hiding this comment.
MakeInvocationExpression below, which is called unconditionally, asserts that the receiver should not be null. We weren't using this incorrectly anywhere that I can see, but the current annotation is still a bug.
|
@dotnet/roslyn-compiler for a quick review. |
RikkiGibson
approved these changes
Feb 26, 2021
jcouv
approved these changes
Feb 26, 2021
jcouv
added
the
Concept-Null Annotations
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a couple of incorrect nullable annotations when looking through local rewriter code. This fixes them up.