Merge master to features/list-patterns

.vscode/launch.json

@@ -12,7 +12,10 @@
  // If you have changed target frameworks, make sure to update the program path.
  "program": "${workspaceFolder}/artifacts/bin/BuildValidator/Debug/netcoreapp3.1/BuildValidator.dll",
  "args": [
- "--assembliesPath", "./artifacts/obj/RunTests",
+ "--assembliesPath", "./artifacts/obj/csc/Debug/netcoreapp3.1",
+ "--referencesPath", "./artifacts/bin",
+ "--referencesPath", "C:/Program Files/dotnet/packs/Microsoft.AspNetCore.App.Ref",
+ "--referencesPath", "C:/Program Files/dotnet/packs/Microsoft.NETCore.App.Ref",
  "--debugPath", "./artifacts/BuildValidator",
  "--sourcePath", "."
  ],

Compilers.sln

@@ -182,6 +182,7 @@ Global
  src\Analyzers\VisualBasic\Analyzers\VisualBasicAnalyzers.projitems*{2531a8c4-97dd-47bc-a79c-b7846051e137}*SharedItemsImports = 5
  src\Workspaces\SharedUtilitiesAndExtensions\Compiler\VisualBasic\VisualBasicCompilerExtensions.projitems*{2531a8c4-97dd-47bc-a79c-b7846051e137}*SharedItemsImports = 5
  src\Analyzers\Core\Analyzers\Analyzers.projitems*{275812ee-dedb-4232-9439-91c9757d2ae4}*SharedItemsImports = 5
+ src\Dependencies\Collections\Microsoft.CodeAnalysis.Collections.projitems*{275812ee-dedb-4232-9439-91c9757d2ae4}*SharedItemsImports = 5
  src\Dependencies\PooledObjects\Microsoft.CodeAnalysis.PooledObjects.projitems*{275812ee-dedb-4232-9439-91c9757d2ae4}*SharedItemsImports = 5
  src\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\CompilerExtensions.projitems*{275812ee-dedb-4232-9439-91c9757d2ae4}*SharedItemsImports = 5
  src\Compilers\Core\CommandLine\CommandLine.projitems*{4b45ca0c-03a0-400f-b454-3d4bcb16af38}*SharedItemsImports = 5

azure-pipelines-integration.yml

@@ -18,10 +18,7 @@ jobs:
 - job: VS_Integration
  pool:
  name: NetCorePublic-Pool
- queue: BuildPool.Windows.VS2019.Pre.Scouting.Open
-# One this integration test fix has flowed in to master-vs-deps, we can update the queueName variable, and revert this change.
-# Tracked by https://github.com/dotnet/roslyn/issues/51312
-# queue: $(queueName)
+ queue: $(queueName)
  strategy:
  maxParallel: 4
  matrix:

azure-pipelines-official.yml

@@ -26,18 +26,26 @@ variables:
  - group: DotNet-GitHub-Versions-Repo-Write
  - name: _DevDivDropAccessToken
  value: $(System.AccessToken)
+ # For publishing from devdiv pipeline to devdiv feed, the API key can 
+ # be any non-empty string as authentication is done in the pipeline. 
+ - name: _DevDivNugetFeedAccessToken
+ value: "AzureArtifacts"
  # If the pipeline is running in dnceng:
- # Get access token with $dn-bot-devdiv-drop-rw-code-rw from DotNet-VSTS-Infra-Access
+ # Get access token with $dn-bot-devdiv-drop-rw-code-rw and dn-bot-dnceng-build-rw-code-rw from DotNet-VSTS-Infra-Access
  # Get $dotnetfeed-storage-access-key-1 from DotNet-Blob-Feed
  # Get $microsoft-symbol-server-pat and $symweb-symbol-server-pat from DotNet-Symbol-Server-Pats
  # Get $AccessToken-dotnet-build-bot-public-repo from DotNet-Versions-Publish
+ # Get $dn-bot-devdiv-packaging-rw from DotNet-DevDiv-Insertion-Workflow-Variables
  - ${{ if eq(variables['System.TeamProject'], 'internal') }}:
  - group: DotNet-Blob-Feed
  - group: DotNet-Symbol-Server-Pats
  - group: DotNet-Versions-Publish
  - group: DotNet-VSTS-Infra-Access
+ - group: DotNet-DevDiv-Insertion-Workflow-Variables
  - name: _DevDivDropAccessToken
  value: $(dn-bot-devdiv-drop-rw-code-rw)
+ - name: _DevDivNugetFeedAccessToken
+ value: $(dn-bot-devdiv-packaging-rw)
 
 stages:
 - stage: build
@@ -109,7 +117,11 @@ stages:
  - task: PowerShell@2
  displayName: Merge master-vs-deps into source branch
  inputs:
- filePath: 'scripts\merge-vs-deps.ps1'
+ filePath: 'scripts\merge-vs-deps.ps1' 
+ ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
+ arguments: '-userName "$(Build.RequestedFor)" -userEmail $(Build.RequestedForEmail)'
+ ${{ if eq(variables['System.TeamProject'], 'internal') }}:
+ arguments: '-userName "$(Build.RequestedFor)" -userEmail $(Build.RequestedForEmail) -accessToken $(dn-bot-dnceng-build-rw-code-rw)'
  condition: and(succeeded(), eq(variables['SourceBranchName'], 'master'))
 
  - powershell: Write-Host "##vso[task.setvariable variable=VisualStudio.DropName]Products/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranchName)/$(Build.BuildNumber)"
@@ -180,7 +192,7 @@ stages:
  displayName: Publish Assets
  inputs:
  filePath: 'eng\publish-assets.ps1'
- arguments: '-configuration $(BuildConfiguration) -branchName "$(SourceBranchName)" -gitHubUserName $(Roslyn.GitHubUserName) -gitHubToken $(AccessToken-dotnet-build-bot-public-repo) -gitHubEmail $(Roslyn.GitHubEmail)'
+ arguments: '-configuration $(BuildConfiguration) -branchName "$(SourceBranchName)" -gitHubUserName $(Roslyn.GitHubUserName) -gitHubToken $(AccessToken-dotnet-build-bot-public-repo) -gitHubEmail $(Roslyn.GitHubEmail) -devdivApiKey $(_DevDivNugetFeedAccessToken)'
  condition: and(succeeded(), eq(variables['PRNumber'], 'default'))
 
  # Publish OptProf configuration files

azure-pipelines.yml

@@ -215,7 +215,8 @@ jobs:
 
 - job: Correctness_Rebuild
  pool:
- vmImage: windows-2019
+ name: NetCorePublic-Pool
+ queue: BuildPool.Windows.10.Amd64.Open
  timeoutInMinutes: 90
  steps:
  - template: eng/pipelines/checkout-windows-task.yml
@@ -226,13 +227,7 @@ jobs:
  filePath: eng/build.ps1
  arguments: -configuration Debug -prepareMachine -ci -restore -binaryLog
 
- - task: PowerShell@2 
- displayName: Build
- inputs:
- filePath: eng/build.ps1
- arguments: -configuration Debug -prepareMachine -ci -build -bootstrap -publish -binaryLog -skipDocumentation
-
- - script: .\artifacts\bin\BuildValidator\Debug\net472\BuildValidator.exe --assembliesPath .\artifacts\obj\Microsoft.CodeAnalysis --debugPath .\artifacts\BuildValidator --sourcePath .
+ - powershell: .\eng\test-rebuild.ps1 -ci -configuration Release
  displayName: Run BuildValidator
 
  - task: PublishBuildArtifacts@1

docs/Language Feature Status.md

@@ -8,25 +8,29 @@ efforts behind them.
 
 # C# Next
 
-| Feature | Branch | State | Developers | Reviewer | LDM Champ |
-|----------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------|------------------------------------------------------------------------------|------------------------------------------------------------------------------------|-----------------------------------------|
-| [Record structs](https://github.com/dotnet/csharplang/issues/4334) | [record-structs](https://github.com/dotnet/roslyn/tree/features/record-structs) | [In Progress](https://github.com/dotnet/roslyn/issues/51199) | [jcouv](https://github.com/jcouv) | TBD | [jcouv](https://github.com/jcouv) |
-| [Global Using Directive](https://github.com/dotnet/csharplang/issues/3428) | [GlobalUsingDirective](https://github.com/dotnet/roslyn/tree/features/GlobalUsingDirective) | [In Progress](https://github.com/dotnet/roslyn/issues/51307) | [AlekseyTs](https://github.com/AlekseyTs) | TBD | [AlekseyTs](https://github.com/AlekseyTs) |
-| [nameof(parameter)](https://github.com/dotnet/csharplang/issues/373) | master | [In Progress](https://github.com/dotnet/roslyn/issues/40524) | [jcouv](https://github.com/jcouv) | TBD | [jcouv](https://github.com/jcouv) |
-| [Relax ordering of `ref` and `partial` modifiers](https://github.com/dotnet/csharplang/issues/946) | [ref-partial](https://github.com/dotnet/roslyn/tree/features/ref-partial) | In Progress | [alrz](https://github.com/alrz) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
-| [Parameter null-checking](https://github.com/dotnet/csharplang/issues/2145) | [param-nullchecking](https://github.com/dotnet/roslyn/tree/features/param-nullchecking) | [In Progress](https://github.com/dotnet/roslyn/issues/36024) | [fayrose](https://github.com/fayrose) | [agocke](https://github.com/agocke) | [jaredpar](https://github.com/jaredpar) |
-| [Caller expression attribute](https://github.com/dotnet/csharplang/issues/287) | [caller-expression](https://github.com/dotnet/roslyn/tree/features/caller-expression) | Prototype | [alrz](https://github.com/alrz) | [jcouv](https://github.com/jcouv) | [jcouv](https://github.com/jcouv) |
-| [Generic attributes](https://github.com/dotnet/csharplang/issues/124) | [generic-attributes](https://github.com/dotnet/roslyn/tree/features/generic-attributes) | [In Progress](https://github.com/dotnet/roslyn/issues/36285) | [AviAvni](https://github.com/AviAvni) | [agocke](https://github.com/agocke) | [mattwar](https://github.com/mattwar) |
-| [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [Implemented](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
-| [Constant Interpolated Strings](https://github.com/dotnet/csharplang/issues/2951) | master | [Merged into 16.9p3](https://github.com/dotnet/roslyn/pull/49676) | [kevinsun-dev](https://github.com/kevinsun-dev) | [333fred](https://github.com/333fred) | [jaredar](https://github.com/jaredpar), [agocke](https://github.com/agocke) |
-| [Mix declarations and variables in deconstruction](https://github.com/dotnet/csharplang/issues/125) | master | [Merged into 16.10](https://github.com/dotnet/roslyn/issues/47746) | [YairHalberstadt ](https://github.com/YairHalberstadt ) | [jcouv](https://github.com/jcouv) | [MadsTorgersen](https://github.com/MadsTorgersen) |
+| Feature | Branch | State | Developers | Reviewer | LDM Champ |
+| ------- | ------ | ----- | ---------- | -------- | --------- |
+| [Record structs](https://github.com/dotnet/csharplang/issues/4334) | [record-structs](https://github.com/dotnet/roslyn/tree/features/record-structs) | [In Progress](https://github.com/dotnet/roslyn/issues/51199) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [RikkiGibson](https://github.com/RikkiGibson) | [jcouv](https://github.com/jcouv) |
+| [Global Using Directive](https://github.com/dotnet/csharplang/issues/3428) | [GlobalUsingDirective](https://github.com/dotnet/roslyn/tree/features/GlobalUsingDirective) | [In Progress](https://github.com/dotnet/roslyn/issues/51307) | [AlekseyTs](https://github.com/AlekseyTs) | [333fred](https://github.com/333fred), [cston](https://github.com/cston) | [AlekseyTs](https://github.com/AlekseyTs) |
+| [File-scoped namespace](https://github.com/dotnet/csharplang/issues/137) | [FileScopedNamespaces](https://github.com/dotnet/roslyn/tree/features/FileScopedNamespaces) | In Progress | [chsienki](https://github.com/chsienki) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
+| [Interpolated string improvements](https://github.com/dotnet/csharplang/issues/2302) | [interpolated-string](https://github.com/dotnet/roslyn/tree/features/interpolated-string) | [In Progress](https://github.com/dotnet/roslyn/issues/51499) | [333fred](https://github.com/333fred) | [AlekseyTs](https://github.com/AlekseyTs), [chsienki](https://github.com/chsienki) | [jaredpar](https://github.com/jaredpar) |
+| [Parameterless struct constructors](https://github.com/dotnet/csharplang/issues/99) | TBD | In Progress | [cston](https://github.com/cston) | [jcouv](https://github.com/jcouv), [333fred](https://github.com/333fred) | [jcouv](https://github.com/jouv) |
+| [nameof(parameter)](https://github.com/dotnet/csharplang/issues/373) | master | [In Progress](https://github.com/dotnet/roslyn/issues/40524) | [jcouv](https://github.com/jcouv) | TBD | [jcouv](https://github.com/jcouv) |
+| [Improved Definite Assignment](https://github.com/dotnet/csharplang/issues/4465) | [improved-definite-assignment](https://github.com/dotnet/roslyn/tree/features/improved-definite-assignment) | [In Progress](https://github.com/dotnet/roslyn/issues/51463) | [RikkiGibson](https://github.com/RikkiGibson) | [jcouv](https://github.com/jcouv) | [jaredpar](https://github.com/jaredpar) |
+| [Relax ordering of `ref` and `partial` modifiers](https://github.com/dotnet/csharplang/issues/946) | [ref-partial](https://github.com/dotnet/roslyn/tree/features/ref-partial) | In Progress | [alrz](https://github.com/alrz) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
+| [Parameter null-checking](https://github.com/dotnet/csharplang/issues/2145) | [param-nullchecking](https://github.com/dotnet/roslyn/tree/features/param-nullchecking) | [In Progress](https://github.com/dotnet/roslyn/issues/36024) | [fayrose](https://github.com/fayrose) | [agocke](https://github.com/agocke) | [jaredpar](https://github.com/jaredpar) |
+| [Caller expression attribute](https://github.com/dotnet/csharplang/issues/287) | [caller-expression](https://github.com/dotnet/roslyn/tree/features/caller-expression) | Prototype | [alrz](https://github.com/alrz) | [jcouv](https://github.com/jcouv) | [jcouv](https://github.com/jcouv) |
+| [Generic attributes](https://github.com/dotnet/csharplang/issues/124) | [generic-attributes](https://github.com/dotnet/roslyn/tree/features/generic-attributes) | [In Progress](https://github.com/dotnet/roslyn/issues/36285) | [AviAvni](https://github.com/AviAvni) | [agocke](https://github.com/agocke) | [mattwar](https://github.com/mattwar) |
+| [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [Implemented](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
+| [Constant Interpolated Strings](https://github.com/dotnet/csharplang/issues/2951) | master | [Merged into 16.9p3](https://github.com/dotnet/roslyn/pull/49676) | [kevinsun-dev](https://github.com/kevinsun-dev) | [333fred](https://github.com/333fred) | [jaredar](https://github.com/jaredpar), [agocke](https://github.com/agocke) |
+| [Mix declarations and variables in deconstruction](https://github.com/dotnet/csharplang/issues/125) | master | [Merged into 16.10](https://github.com/dotnet/roslyn/issues/47746) | [YairHalberstadt ](https://github.com/YairHalberstadt) | [jcouv](https://github.com/jcouv) | [MadsTorgersen](https://github.com/MadsTorgersen) |
 | [List patterns](https://github.com/dotnet/csharplang/issues/3435) | [list-patterns](https://github.com/dotnet/roslyn/tree/features/list-patterns) | [In Progress](https://github.com/dotnet/roslyn/issues/51289) | [alrz](https://github.com/alrz) | [333fred](https://github.com/333fred) (tentative) | [333fred](https://github.com/333fred) |
 
 # VB 16.9
 
-| Feature  | Branch    | State | Developers  | Reviewer  | LDM Champ  |
-|----------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------|------------------------------------------------------------------------------|------------------------------------------------------------------------------------|-----------------------------------------|
-| [Enable consumption of init-only properties](https://github.com/dotnet/roslyn/pull/50414) | master  | [Merged (16.9p3)](https://github.com/dotnet/roslyn/issues/50792)  | [AlekseyTs](https://github.com/AlekseyTs) | [jcouv](https://github.com/jcouv)   
+| Feature | Branch | State | Developers | Reviewer | LDM Champ |
+|-------------------------------------------------------------------------------------------|--------|------------------------------------------------------------------|-------------------------------------------|-----------------------------------|-----------|
+| [Enable consumption of init-only properties](https://github.com/dotnet/roslyn/pull/50414) | master | [Merged (16.9p3)](https://github.com/dotnet/roslyn/issues/50792) | [AlekseyTs](https://github.com/AlekseyTs) | [jcouv](https://github.com/jcouv) | N/A  |
 
 # C# 9
 

eng/Version.Details.xml

@@ -7,9 +7,9 @@
  <Uri>https://github.com/dotnet/arcade</Uri>
  <Sha>4957a6f3dd5f6fd1ca9ff06f9c50402f2e3b17e8</Sha>
  </Dependency>
- <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.10.0-1.21113.12">
+ <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.10.0-2.21122.2">
  <Uri>https://github.com/dotnet/roslyn</Uri>
- <Sha>69f354dd21df8dac374c35169bdabb9000cfdea3</Sha>
+ <Sha>686f13c61b1e26071ae89e107b0a3407a6b93a74</Sha>
  </Dependency>
  <Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="2.0.0-beta.21118.7">
  <Uri>https://github.com/dotnet/arcade</Uri>