Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove namespace test filter #51632

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Remove namespace test filter #51632

merged 1 commit into from
Mar 3, 2021

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Mar 3, 2021

From #49996, implementing suggestion to merge gotodef test and remove namespace filter. In cases where we need to have a test only run under LSP, we can use a ConditionalWpfFact.

@dibarbet dibarbet requested review from a team as code owners March 3, 2021 18:45
jasonmalinowski
jasonmalinowski approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dibarbet dibarbet merged commit 33608c5 into dotnet:master Mar 3, 2021
@ghost ghost added this to the Next milestone Mar 3, 2021
@dibarbet dibarbet deleted the lsp_test_filter branch March 3, 2021 20:09
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
16.10.P2
Development

Successfully merging this pull request may close these issues.
3 participants
@dibarbet @jasonmalinowski @allisonchou