Document breaking change for #50755 #51754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
reviewed
Mar 9, 2021
| @@ -11,3 +11,22 @@ | |||
| t2 = (T?)obj; // ok | |||
| } | |||
| ``` | |||
|
|
|||
| 2. https://github.com/dotnet/roslyn/pull/50755 In .NET 5.0.200 (Visual Studio 16.9), if there is a common type between the two branches of a conditional expression, that type is the type of the conditional expression. This is a breaking change from 5.0.103 (Visual Studio 16.8) which incorrectly used the target type of the conditional expression as the type even if there was a common type between the two branches. This latest change aligns the compiler behavior with the C# specification and with versions of the compiler before .NET 5.0. | |||
There was a problem hiding this comment.
nit: consider breaking line #Resolved
jcouv
approved these changes
Mar 9, 2021
jaredpar
reviewed
Mar 9, 2021
| @@ -11,3 +11,22 @@ | |||
| t2 = (T?)obj; // ok | |||
| } | |||
| ``` | |||
|
|
|||
| 2. https://github.com/dotnet/roslyn/pull/50755 In .NET 5.0.200 (Visual Studio 16.9), if there is a common type between the two branches of a conditional expression, that type is the type of the conditional expression. This is a breaking change from 5.0.103 (Visual Studio 16.8) which incorrectly used the target type of the conditional expression as the type even if there was a common type between the two branches. This latest change aligns the compiler behavior with the C# specification and with versions of the compiler before .NET 5.0. | |||
There was a problem hiding this comment.
Suggested change
| 2. https://github.com/dotnet/roslyn/pull/50755 In .NET 5.0.200 (Visual Studio 16.9), if there is a common type between the two branches of a conditional expression, that type is the type of the conditional expression. This is a breaking change from 5.0.103 (Visual Studio 16.8) which incorrectly used the target type of the conditional expression as the type even if there was a common type between the two branches. This latest change aligns the compiler behavior with the C# specification and with versions of the compiler before .NET 5.0. | |
| 2. https://github.com/dotnet/roslyn/pull/50755 In .NET 5.0.200 (Visual Studio 16.9), if there is a common type between the two branches of a conditional expression, that type is the type of the conditional expression. This is a breaking change from 5.0.103 (Visual Studio 16.8) which due to a bug incorrectly used the target type of the conditional expression as the type even if there was a common type between the two branches. This latest change aligns the compiler behavior with the C# specification and with versions of the compiler before .NET 5.0. | |
| ``` #Resolved |
jaredpar
approved these changes
Mar 9, 2021
AlekseyTs
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document breaking change for #50755