Don't use docker for sourcebuild leg #51815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RikkiGibson @jaredpar for review. |
jaredpar
approved these changes
Mar 12, 2021
|
@333fred do you know what the rationale was for using docker for source build in the first place? (and conversely is there a reason we're getting rid of it?) |
The rationale was "This is what every other build was doing". The rationale is still "This is what every build is doing." |
333fred
pushed a commit
that referenced
this pull request
Apr 29, 2021
It doesn't seem to be used anymore after #51815
JoeRobich
pushed a commit
to JoeRobich/roslyn
that referenced
this pull request
May 12, 2022
It doesn't seem to be used anymore after dotnet#51815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.