Simplify CSharpRequiredLanguageVersion #51881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LanguageVersion.Preview.MapSpecifiedToEffectiveVersion()
will always return "Preview" as far as I understand. See:roslyn/src/Compilers/CSharp/Portable/LanguageVersion.cs
Lines 370 to 384 in 6da1274
Thus, the
Version
property is always set toversion
.Did Preview in past used to map to a language version?
Could this be taken further and simplify all(Probably not possible - Seenew CSharpRequiredLanguageVersion(...)
, and even trying to get rid of the class (if possible)?string? GetRequiredLanguageVersion(Diagnostic diagnostic)
- But I'll give it a try later)