Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to underline variables in the editor that are reassigned. #51889

Merged
merged 73 commits into from
May 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
abfa141
Initial stubs
CyrusNajmabadi Mar 15, 2021
c6b24d3
Add option
CyrusNajmabadi Mar 15, 2021
f4788b4
Body of tagger
CyrusNajmabadi Mar 15, 2021
651ab64
Define apoi
CyrusNajmabadi Mar 15, 2021
70c4602
Implement logic for C#
CyrusNajmabadi Mar 15, 2021
95925b8
revert
CyrusNajmabadi Mar 15, 2021
acfb4b0
Switch to a short delay
CyrusNajmabadi Mar 15, 2021
5bf3abe
Less allocations
CyrusNajmabadi Mar 15, 2021
cb00f07
Nullable
CyrusNajmabadi Mar 15, 2021
bf9ca78
Add doc
CyrusNajmabadi Mar 15, 2021
6e2e788
Simplify
CyrusNajmabadi Mar 15, 2021
99cfe68
Basic tests
CyrusNajmabadi Mar 15, 2021
9eb0a5f
Add option
CyrusNajmabadi Mar 15, 2021
dab5ec5
Add option
CyrusNajmabadi Mar 15, 2021
5136f84
Reorder
CyrusNajmabadi Mar 15, 2021
207696f
add vb option
CyrusNajmabadi Mar 15, 2021
d398c43
VBfixes
CyrusNajmabadi Mar 15, 2021
e15714c
build
CyrusNajmabadi Mar 15, 2021
6e05fd7
Do not allocate
CyrusNajmabadi Mar 15, 2021
08c5bc8
More tests
CyrusNajmabadi Mar 15, 2021
aab4f32
Add support for indexers
CyrusNajmabadi Mar 15, 2021
dabbb04
Add more cases
CyrusNajmabadi Mar 15, 2021
6c08cf3
Fix test
CyrusNajmabadi Mar 15, 2021
f4ee084
Add tests
jnm2 Mar 16, 2021
c226cce
Generate VB tests
jnm2 Mar 16, 2021
3586a2a
Merge pull request #13 from jnm2/underlingVariables_tests
CyrusNajmabadi Mar 16, 2021
1a5c7e7
Support pointers
CyrusNajmabadi Mar 16, 2021
6c3a873
Fix test
CyrusNajmabadi Mar 16, 2021
929643a
Fix test
CyrusNajmabadi Mar 16, 2021
d08289a
Improved behavior
CyrusNajmabadi Mar 16, 2021
5b2f4d9
Fix remaining C# issues. unify code.
CyrusNajmabadi Mar 16, 2021
ced10b5
VBside working
CyrusNajmabadi Mar 16, 2021
2593979
Support writes through ref-extension methods.
CyrusNajmabadi Mar 16, 2021
7df5fc9
Cancellation
CyrusNajmabadi Mar 16, 2021
45edf1a
Add test
CyrusNajmabadi Mar 16, 2021
18715f4
Avoid data flow if unnecessary.
CyrusNajmabadi Mar 16, 2021
660bc7b
Add docs
CyrusNajmabadi Mar 16, 2021
eea7716
Simplify
CyrusNajmabadi Mar 16, 2021
4a5e639
Docs
CyrusNajmabadi Mar 16, 2021
0a37922
Fix and tests for global statements
CyrusNajmabadi Mar 16, 2021
0c66a0c
Add tests
CyrusNajmabadi Mar 16, 2021
9775ccf
Add tests
CyrusNajmabadi Mar 16, 2021
3a6e8a7
Doc
CyrusNajmabadi Mar 16, 2021
1522541
Add tests of event accessor parameter reassignment
jnm2 Mar 16, 2021
89d5d78
Misc tests, three failing
jnm2 Mar 16, 2021
9762e74
null ref
CyrusNajmabadi Mar 17, 2021
bd4113f
Merge pull request #14 from jnm2/underlingVariables_tests
CyrusNajmabadi Mar 17, 2021
e73d1c0
Support top level args
CyrusNajmabadi Mar 17, 2021
195af50
Blank line
CyrusNajmabadi Mar 17, 2021
88f6256
Null checks
CyrusNajmabadi Mar 17, 2021
7609e6f
Update src/Features/Core/Portable/ReassignedVariable/ReassignedVariab…
CyrusNajmabadi Mar 18, 2021
aed9847
Merge branch 'master' into underlingVariables
CyrusNajmabadi Mar 22, 2021
e128051
UPdate resxs
CyrusNajmabadi Mar 22, 2021
fa62450
Merge remote-tracking branch 'upstream/main' into underlingVariables
CyrusNajmabadi Apr 1, 2021
43afd6d
Merge remote-tracking branch 'upstream/main' into underlingVariables
CyrusNajmabadi May 18, 2021
d3f8fae
Fix
CyrusNajmabadi May 18, 2021
0e3bfd7
Fix
CyrusNajmabadi May 18, 2021
bc780ce
Switch to being part of the standard classification system
CyrusNajmabadi May 18, 2021
aa63544
Add tests
CyrusNajmabadi May 18, 2021
9143ff7
Add test
CyrusNajmabadi May 18, 2021
3ab4a9f
Make internal
CyrusNajmabadi May 18, 2021
d7ac5aa
MOve options
CyrusNajmabadi May 18, 2021
4b0b59a
Add comment
CyrusNajmabadi May 18, 2021
7a2b25b
Add test
CyrusNajmabadi May 18, 2021
1611f50
Support ref readonly varaibles
CyrusNajmabadi May 18, 2021
41471fc
Add test
CyrusNajmabadi May 18, 2021
c141e47
Fix tagger
CyrusNajmabadi May 18, 2021
ea44fef
Simplify
CyrusNajmabadi May 18, 2021
ed550f7
Merge remote-tracking branch 'upstream/main' into underlingVariables
CyrusNajmabadi May 25, 2021
a6f459f
Add tests
CyrusNajmabadi May 25, 2021
c1f5f86
Add comments
CyrusNajmabadi May 25, 2021
48a60d3
REname method
CyrusNajmabadi May 25, 2021
a62de54
NRTenable
CyrusNajmabadi May 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ private static bool CanReplaceAnonymousWithLocalFunction(
if (identifierName.Identifier.ValueText == local.Name &&
local.Equals(semanticModel.GetSymbolInfo(identifierName, cancellationToken).GetAnySymbol()))
{
if (identifierName.IsWrittenTo())
if (identifierName.IsWrittenTo(semanticModel, cancellationToken))
{
// Can't change this to a local function if it is assigned to.
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ private void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)
// Check if this is a 'write' to the asOperand.
if (identifierName.Identifier.ValueText == asOperand?.Name &&
asOperand.Equals(semanticModel.GetSymbolInfo(identifierName, cancellationToken).Symbol) &&
identifierName.IsWrittenTo())
identifierName.IsWrittenTo(semanticModel, cancellationToken))
{
return;
}
Expand Down
Loading