Add value tracking service #51898
Merged
Add value tracking service #51898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into feature/value_tracking
ryzngard
force-pushed
the
feature/value_tracking/service
branch
from
68faad4
to
2906847
Compare
ryzngard
changed the base branch from
feature/value_tracking
to
features/value_tracking
ryzngard
force-pushed
the
feature/value_tracking/service
branch
from
d4fec99
to
ef3c027
Compare
jmarolf
reviewed
Mar 19, 2021
|
|
||
| namespace Microsoft.CodeAnalysis.ValueTracking | ||
| { | ||
| internal class ValueTrackedItem |
There was a problem hiding this comment.
Actually, can we use records in Roslyn yet?
Severity Code Description Project File Line Suppression State
Error CS0518 Predefined type 'System.Runtime.CompilerServices.IsExternalInit' is not defined or imported Microsoft.CodeAnalysis.EditorFeatures (netcoreapp3.1)
jmarolf
reviewed
Mar 19, 2021
src/EditorFeatures/Core/ValueTracking/ValueTrackingProgressCollector.cs
Outdated
Show resolved
Hide resolved
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the initial implementation of the value tracking service into the feature branch. The design here is to showcase initial expansion based on entry point from a user. The service returns a set of references that may be further expanded if needed, but is currently not implemented to do so. Does not include UI