Always set RestoreUseStaticGraphEvaluation to true

[sharwell]

Opening so we can discuss why this would or would not be desirable.

/cc @tmat @jmarolf

[jmarolf]

@sharwell there is no reason to not do this. The VS version we were building against in the past was not always compatible with this option. However, we should already be doing this for all restores via build.ps1 here

[sharwell]

@jmarolf If we're already setting this flag for improved restore performance in command line builds:

1. Why are we not also setting this flag for restore inside the IDE?
2. If this mode is faster and produces correct results, why is it an option?
3. As a follow-up to (2), why is the option disabled by default?

[Youssef1313]

@sharwell NuGet/Home#9803 tracks enabling it by default. Probably it was disabled by default as it's experimental feature.

[jmarolf]

1. I forget that the VS restore is different :( my main situation was trying to improve CI times
2. and 3. ¯_(ツ)_/¯ up to nuget team

[sharwell]

@nkolev92 any reason for us to not merge this?

[nkolev92]

Nope, as long as you do the equivalency test mentioned in the body of NuGet/Home#9803 and it passes, you are all good.

[sharwell]

Verified that equivalency test passed.

[jaredpar]

Can we avoid blank lines before after properties in property blocks? Unless there is a comment prefer we just group them together.

[jaredpar]

Why didn't we delete this when merging this change?

https://github.com/dotnet/roslyn/blob/main/eng/build.ps1#L270

[sharwell]

Why didn't we delete this when merging this change?

The line in build.ps1 applies to pseudo-projects with broader scope than what gets applied for restore operations that occur within Visual Studio.