Handle expressions and method calls #52127
Conversation
ryzngard
added
the
Feature - IDE Value Tracking
|
|
||
| namespace Microsoft.CodeAnalysis.ValueTracking | ||
| { | ||
| internal interface IValueTrackingService : IWorkspaceService | ||
| { | ||
| Task<ImmutableArray<ValueTrackedItem>> TrackValueSourceAsync(Solution solution, ISymbol symbol, CancellationToken cancellationToken); | ||
| Task TrackValueSourceAsync(Solution solution, ISymbol symbol, ValueTrackingProgressCollector progressCollector, CancellationToken cancellationToken); | ||
| Task<ImmutableArray<ValueTrackedItem>> TrackValueSourceAsync(TextSpan selection, Document document, CancellationToken cancellationToken); |
There was a problem hiding this comment.
Why isn't the non-progress-reporting version just an extension/helper method that just collects the items and returns them all in one go?
There was a problem hiding this comment.
It basically is... I can add as an implementation in the interface rather than leaving it as a contract. That seems more clear than an extension method just for code navigation
| var node = location.FindNode(cancellationToken); | ||
| var sourceDoc = document.Project.Solution.GetRequiredDocument(location.SourceTree); | ||
| var syntaxFacts = sourceDoc.GetRequiredLanguageService<ISyntaxFactsService>(); | ||
| var returnStatements = node.DescendantNodesAndSelf().Where(n => syntaxFacts.IsReturnStatement(n)).ToImmutableArray(); |
There was a problem hiding this comment.
Does this need to ensure it doesn't descend into nested local functions or lambdas?
There was a problem hiding this comment.
Not sure yet, after finishing up some of the expression and method call situations lambdas and locals are next
|
|
||
| public ValueTask OnFindInDocumentStartedAsync(Document document) => new(); | ||
| await TrackExpressionAsync(operation, sourceDoc, progressCollector, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
This is identical to the if block?
| var expression = node.DescendantNodesAndSelf().First(syntaxFacts.IsMethodBody); | ||
| if (expression is null) | ||
| { | ||
| return; |
There was a problem hiding this comment.
Should this be continue, so processing out params isn't skipped?
There was a problem hiding this comment.
Let me get a test for out params, but I think you're right.
There was a problem hiding this comment.
It does need to continue, but there are some nuances that need to be handled for adding tests. I'm going to do that in the next PR and address this issue. Will link once the PR is up
Co-authored-by: David Wengier <david.wengier@microsoft.com>
…ps://github.com/ryzngard/roslyn into feature/value_tracking/handle_single_expression
ghost
merged commit 
The service should now handle tracking expressions and method calls from previous items correctly. It's hard to explain all done here, but the tests added should highlight new functionality pretty well.
TODO: VB Tests