Fix non-leaf active statement spans when entering break mode with unapplied run-mode changes #52157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1301343 for non-leaf active statements. Leaf active statements are still off since they are rendered by the debugger and a fix needs to be made there as well. This issue is not new to F5 Hot Reload, but previously was not significant since applying changes while the app is running was not possible and thus users wouldn't run into this issue often.
This change also makes active statement span tracking start deterministic. Previously we did not await the start since it might be costly and the debugger was blocking on entering break mode. The debugger does not block anymore and thus we can await the operation and make the behavior deterministic.