Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/dev16.10-vs-deps to main-vs-deps #52350

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Merge release/dev16.10-vs-deps to main-vs-deps #52350

merged 3 commits into from
Apr 2, 2021

Commits on Apr 1, 2021

  1. Fix global option service to handle non-default values from persisters 

    Fixes [AB#1128126](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1128126)

Currently, the global option service only tracks explicitly changed option keys. This means options that have non-default values from option persisters are not part of tracked changed option keys, which leads to GlobalOptionService.SetOptions to ignore these options until an actual new solution snapshot is produced with the non-default option value.

Verified customer repro and added unit test failure prior to the fix.
    @mavasani
    mavasani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    31570ce View commit details
    Browse the repository at this point in the history

  2. Merge pull request #52335 from mavasani/FixTodoCommentsIssue 

    Fix global option service to handle non-default values from persisters
    @mavasani
    mavasani authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    f3a4878 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #52345 from dotnet/merges/release/dev16.10-to-rele… 

    …ase/dev16.10-vs-deps

Merge release/dev16.10 to release/dev16.10-vs-deps
    @allisonchou
    allisonchou authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    355e3f6 View commit details
    Browse the repository at this point in the history