Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record-structs: adjust symbol display and QuickInfo #52455

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Apr 7, 2021

Test plan #51199

@jcouv jcouv marked this pull request as ready for review April 7, 2021 03:14
@jcouv jcouv requested review from a team as code owners April 7, 2021 03:14
@jcouv jcouv mentioned this pull request Apr 7, 2021
92 tasks
@jcouv
Copy link
Member Author

jcouv commented Apr 7, 2021

@AlekseyTs @RikkiGibson @dotnet/roslyn-compiler for review. Thanks

@@ -447,12 +447,14 @@ static void validateModule(ModuleSymbol module)
Assert.True(point is SourceNamedTypeSymbol);
Assert.True(point.IsRecordStruct);
Assert.True(point.GetPublicSymbol().IsRecord);
Assert.Equal("record struct Point", point.ToDisplayString(SymbolDisplayFormat.TestFormat.AddKindOptions(SymbolDisplayKindOptions.IncludeTypeKeyword)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IncludeTypeKeyword [](start = 149, length = 18)

It would be good to observe behavior without this option.

}
else
{
Assert.True(point is PENamedTypeSymbol);
Assert.False(point.IsRecordStruct);
Assert.False(point.GetPublicSymbol().IsRecord);
Assert.Equal("struct Point", point.ToDisplayString(SymbolDisplayFormat.TestFormat.AddKindOptions(SymbolDisplayKindOptions.IncludeTypeKeyword)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IncludeTypeKeyword [](start = 142, length = 18)

Similar here.

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jcouv jcouv enabled auto-merge (squash) April 8, 2021 17:56
@jcouv jcouv merged commit 7f3ffe4 into dotnet:features/record-structs Apr 8, 2021
@jcouv jcouv deleted the rs-display branch April 8, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants