Add publish data for d17p1 branch #52510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu
approved these changes
Apr 8, 2021
JoeRobich
approved these changes
Apr 8, 2021
| "version": "4.0.*", | ||
| "packageFeeds": "default", | ||
| "channels": [], | ||
| "vsBranch": "main", |
There was a problem hiding this comment.
Suggested change
| "vsBranch": "main", | |
| "vsBranch": "feature/d17initial", |
There was a problem hiding this comment.
I think this branch is only used in partner previews, by the time we reach p2 I think this branch will no longer be used. So should we just set this to main for now?
There was a problem hiding this comment.
I need to dig and see what the vsBranch is used for. I feel like it is the optprof related, but since we aren't inserting it isn't likely an issue.
There was a problem hiding this comment.
There was a problem hiding this comment.
I guess I'm not sure if this should use p1 data or main data since neither are merging into this branch.
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.