TrimTrailingSeparators on GetRelativePath #52912
Conversation
| @@ -534,6 +534,9 @@ public static string GetRelativePath(string directory, string fullPath) | |||
| { | |||
| string relativePath = string.Empty; | |||
|
|
|||
| directory = TrimTrailingSeparators(directory); | |||
| fullPath = TrimTrailingSeparators(fullPath); | |||
|
|
|||
There was a problem hiding this comment.
this is always terrifying to me. Is there a reason we have our own GetRelativePath? I thought this was something the platform provided. If we write our own, won't we always have the risk of just deviating and needing to continually patch like this?
There was a problem hiding this comment.
Can you remove this entirely and switch to https://docs.microsoft.com/en-us/dotnet/api/system.io.path.getrelativepath?view=net-5.0 ?
There was a problem hiding this comment.
because Path.GetRelativePath doesn't exist in .NET Framework of .NET Standard I assume? @dotnet/roslyn-compiler
There was a problem hiding this comment.
That's correct. I don't know if it would be better to use the platform implementation on TFMs where it's available, and fall back to our own implementation otherwise, since if there are bugs with this it may make it harder to reproduce them.
As far as copying the platform implementation, that may help, if the implementation doesn't depend on too much stuff within dotnet/runtime. If it's practical to copy the tests for this method from dotnet/runtime repo that might be helpful too. I consider both to be up to the author's discretion here.
There was a problem hiding this comment.
I agree that its would be much better if we called the underlying platform apis on .NET Core and newer. The question is whether we want #51602 to make 16.10. we basically have today and tomorrow to get this in if we do.
| { | ||
| var expected = ""; | ||
| var result = PathUtilities.GetRelativePath(@"C:\A\B\", @"C:\A\B"); | ||
| Assert.Equal(expected, result); |
There was a problem hiding this comment.
instead of making this windows only, can we instead just build the string using the platform sepaarator? or, barring that, have some tests for non-windows?
jmarolf
force-pushed
the
bugfix/namespace-path-index-out-of-range
branch
from
d0462a1
to
e7b7556
Compare
|
Filed #52936 to resolve what the correct thing to do with our poor duplicate implementation of GetRelativePath |
ghost
added this to the 
|
Thank you 💜 |
|
@jmarolf hi. I am facing this issue now in a project of mine. I see you have a fix checked in. But how do we get it ? is there any workaround to this? I am kind of blocked in what i am doing. thoughts? |
fixes #51602