Port ExternalAccess.OmniSharp to 16.11 #53168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 979231a)
(cherry picked from commit 4ffbfe4)
(cherry picked from commit 253846b)
(cherry picked from commit af971c0)
(cherry picked from commit ef9956d)
(cherry picked from commit 318d1d8)
(cherry picked from commit d5f494d)
(cherry picked from commit 6a1c39e)
(cherry picked from commit f6ddd0b)
(cherry picked from commit 08b911d)
(cherry picked from commit ccd1633)
(cherry picked from commit 697a9d2)
(cherry picked from commit d92b546)
(cherry picked from commit bf24e97)
(cherry picked from commit 2b118dd)
(cherry picked from commit bc92a47)
(cherry picked from commit 268f94d)
|
Sure, I would take care of this when it flows to main |
JoeRobich
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #52907 to the 16.11 branch so OmniSharp can use a non-4.0 version of roslyn. The only new commit in this PR is the last one, which fixes up the
OmniSharpPickMembersServiceto compile for 16.11. @Cosifne, when this makes its way through codeflow to main, we'll want to revert just that one commit (28955d0).