Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Require partial method signatures to match" (47576) (#47879)" #53352

Merged
merged 20 commits into from
Jun 10, 2021
Merged

Revert "Revert "Require partial method signatures to match" (47576) (#47879)" #53352

merged 20 commits into from
Jun 10, 2021

Commits on May 12, 2021

  1. Revert "Revert "Require partial method signatures to match" (47576) (d… 

    …otnet#47879)"

This reverts commit c785833.
    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    0c63203 View commit details
    Browse the repository at this point in the history

  2. Fix conflicts

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    0e366d9 View commit details
    Browse the repository at this point in the history

  3. Move to warning level 6

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    e01db55 View commit details
    Browse the repository at this point in the history

  4. Report warning on different parameter names

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    41d05ee View commit details
    Browse the repository at this point in the history

  5. Update tests

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    528d481 View commit details
    Browse the repository at this point in the history

  6. Fix few tests

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    10bebc9 View commit details
    Browse the repository at this point in the history

  7. Fix nullability mismatch check

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    1342efe View commit details
    Browse the repository at this point in the history

  8. Fix more tests

    @Youssef1313
    Youssef1313 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    8d0573f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Address feedback

    @Youssef1313
    Youssef1313 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    e98d8e3 View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @Youssef1313
    Youssef1313 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    81e51e9 View commit details
    Browse the repository at this point in the history

  3. Fix previous commit :/

    @Youssef1313
    Youssef1313 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    c2e51f2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Doc

    @Youssef1313
    Youssef1313 committed May 28, 2021
    Configuration menu
    Copy the full SHA
    bbb77c8 View commit details
    Browse the repository at this point in the history

  2. Report on type parameter name differences

    @Youssef1313
    Youssef1313 committed May 28, 2021
    Configuration menu
    Copy the full SHA
    fc4b3a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Fix tests

    @Youssef1313
    Youssef1313 committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    4adfba6 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. Update src/Compilers/CSharp/Portable/CSharpResources.resx 

    Co-authored-by: Rikki Gibson <rigibson@microsoft.com>
    @Youssef1313 @RikkiGibson
    Youssef1313 and RikkiGibson authored Jun 6, 2021
    Configuration menu
    Copy the full SHA
    166cd06 View commit details
    Browse the repository at this point in the history

  2. Update Xlf

    @Youssef1313
    Youssef1313 committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    5ef3891 View commit details
    Browse the repository at this point in the history

  3. Update test comments

    @Youssef1313
    Youssef1313 committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    0e11e7f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Rikki Gibson <rigibson@microsoft.com>
    @Youssef1313 @RikkiGibson
    Youssef1313 and RikkiGibson authored Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9e7e97d View commit details
    Browse the repository at this point in the history

  2. feedback

    @Youssef1313
    Youssef1313 authored Jun 10, 2021
    Configuration menu
    Copy the full SHA
    d50777d View commit details
    Browse the repository at this point in the history

  3. Fix warning title

    @Youssef1313
    Youssef1313 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    ea4bb7e View commit details
    Browse the repository at this point in the history