Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API Review Process Documentation #53396

Merged
merged 10 commits into from
May 27, 2021
Merged

Add API Review Process Documentation #53396

merged 10 commits into from
May 27, 2021

Commits on May 13, 2021

  1. Add API Review Process Documentation 

    We're currently working on making a more formal API review process for Roslyn. This PR adds documentation to the repo on how that process works, and the general expectations for how the process should work. Much of this documentation is copied from dotnet/runtime, and modified to fit the repo. Still to be done:

* [ ] Get a board on apireviews.net/backlog (cc @terrajobst).
* [ ] List areas and owners for the IDE layers (cc @jasonmalinowski and @JoeRobich).
* [ ] Set up the email aliases and meeting schedules.
* [ ] Add examples of a good API request (this may come later).
* [ ] Broad messaging to the roslyn team.
    @333fred
    333fred committed May 13, 2021
    Configuration menu
    Copy the full SHA
    9161eb8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Joseph Musser <me@jnm2.com>
    @333fred @Youssef1313 @jnm2
    3 people committed May 18, 2021
    Configuration menu
    Copy the full SHA
    50d7bba View commit details
    Browse the repository at this point in the history

  2. Further updates.

    @333fred
    333fred committed May 18, 2021
    Configuration menu
    Copy the full SHA
    a46bf07 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. More updates, add section to the CODEOWNERS file.

    @333fred
    333fred committed May 19, 2021
    Configuration menu
    Copy the full SHA
    4b9e488 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Joseph Musser <me@jnm2.com>
    @333fred @jnm2
    333fred and jnm2 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    73b7861 View commit details
    Browse the repository at this point in the history

  3. Add IDE areas and owners to areas list

    @JoeRobich
    JoeRobich committed May 19, 2021
    Configuration menu
    Copy the full SHA
    9e4327c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Merge pull request #3 from JoeRobich/add-ide-areas 

    Add IDE areas and owners to areas list
    @333fred
    333fred committed May 20, 2021
    Configuration menu
    Copy the full SHA
    3513e1a View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Update link

    @333fred
    333fred committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4c8563a View commit details
    Browse the repository at this point in the history

  2. Use brackets for link. 

    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    @333fred @Youssef1313
    333fred and Youssef1313 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7a97d84 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Update wording.

    @333fred
    333fred committed May 27, 2021
    Configuration menu
    Copy the full SHA
    f446eb2 View commit details
    Browse the repository at this point in the history