Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Infer delegate types with -langversion:preview only (#53241)" #53466

Merged
merged 1 commit into from
May 18, 2021

Conversation

cston
Copy link
Member

@cston cston commented May 17, 2021

This reverts commit 82ce937.

The change in #53241 - to infer delegate types with -langversion:preview only - was intended as a temporary change, for 16.11.

Test plan: #52192

@cston cston requested a review from a team as a code owner May 17, 2021 19:15
@cston cston added this to the C# 10 milestone May 17, 2021
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@cston cston merged commit 7d461ed into dotnet:main May 18, 2021
@ghost ghost modified the milestones: C# 10, Next May 18, 2021
@cston cston deleted the revert-53241 branch May 18, 2021 00:32
333fred added a commit to 333fred/roslyn that referenced this pull request May 20, 2021
…vice-featureslayer

* upstream/main: (857 commits)
  Update contrib documentation (dotnet#53504)
  SImplify
  Fix out of bound crash in lsp navto.
  Revert changes to TypeScriptWaitContext wrappers
  Switch to ROSLYN_TEST_CI for CI detection
  SImplify
  Simplify LoggerTestChannel using BlockingCollection
  Only require telemetry validation in CI
  Fix out of bound crash in lsp navto.
  Fix locked comment
  Update Compiler Test Plan.md (dotnet#53420)
  Adjust doc comment for NullableWalker.VisitConversion (dotnet#53429)
  Revert "Infer delegate types with -langversion:preview only (dotnet#53241)" (dotnet#53466)
  Fix syntax normalizer to add space around before colon in constructor initializer (dotnet#53326)
  Remove unnecessary property (dotnet#53406)
  EnC - Tell the debugger about updated type def tokens (dotnet#53217)
  Revert an error
  Update PublishData.json
  Keep trailing trivia so single line if statements don't get badly formatted (dotnet#53414)
  Fix dead test code (dotnet#53416)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
cston added a commit to cston/roslyn that referenced this pull request Jul 29, 2021
cston added a commit that referenced this pull request Jul 29, 2021
Revert "Revert "Infer delegate types with -langversion:preview only (#53241)" (#53466)"

This reverts commit 7d461ed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants