Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding zoom level to Inheritance margin #53534

Merged
merged 1 commit into from
May 28, 2021
Merged

Binding zoom level to Inheritance margin #53534

merged 1 commit into from
May 28, 2021

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented May 20, 2021 •
edited
Loading

Binding to zoom level of TextView to ScaleFactor of CrispImage.
I
Before:
image

After:
image

@Cosifne Cosifne requested a review from a team as a code owner May 20, 2021 06:56
davidwengier
davidwengier approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixes #53372 perhaps?

sharwell
sharwell previously requested changes May 20, 2021
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to listen for ZoomLevelChanged. See here for example:

https://devdiv.visualstudio.com/DevDiv/_git/VS?path=%2Fsrc%2Fdebugger%2Fvsdebugcoreui%2FExceptionHelper%2FSession.cs&version=GBmain&line=643&lineEnd=683&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

@Cosifne
Copy link
Member Author

Cosifne commented May 20, 2021

Looks like this fixes #53372 perhaps?

Yes

@sharwell sharwell dismissed their stale review May 20, 2021 22:00

It appears that the editor recreates glyphs when the zoom level changes

@Cosifne Cosifne changed the base branch from release/dev16.11-vs-deps to release/dev16.11 May 27, 2021 18:13
@Cosifne
Copy link
Member Author

Cosifne commented May 28, 2021

@vatsalyaagrawal for approval

@Cosifne Cosifne merged commit 9f1db5e into dotnet:release/dev16.11 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@sharwell sharwell sharwell left review comments

Assignees
No one assigned
Labels
Approved to merge Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cosifne @davidwengier @sharwell @jinujoseph