Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move language version check for syntax node action to compilation start #53630

Merged
merged 1 commit into from
May 25, 2021
Merged

Move language version check for syntax node action to compilation start #53630

merged 1 commit into from
May 25, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 23, 2021 •
edited
Loading

Note: I haven't checked other analyzers, nor benchmarked. But thought this is a good practice anyway.

@Youssef1313
Copy link
Member Author 

D:\workspace\_work\1\s\src\Scripting\CSharp\Microsoft.CodeAnalysis.CSharp.Scripting.csproj : error NU3037: Package 'System.Reflection.Emit 4.3.0' from source 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json': The repository primary signature validity period has expired. [D:\workspace\_work\1\s\src\NuGet\Microsoft.Net.Compilers.Toolset\Microsoft.Net.Compilers.Toolset.Package.csproj]
D:\workspace\_work\1\s\src\Scripting\CSharp\Microsoft.CodeAnalysis.CSharp.Scripting.csproj : error NU3037: Package 'Microsoft.NETCore.Targets 1.1.0' from source 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json': The repository primary signature validity period has expired. [D:\workspace\_work\1\s\src\NuGet\Microsoft.Net.Compilers.Toolset\Microsoft.Net.Compilers.Toolset.Package.csproj]
D:\workspace\_work\1\s\src\Scripting\CSharp\Microsoft.CodeAnalysis.CSharp.Scripting.csproj : error NU3037: Package 'System.Threading.Tasks 4.3.0' from source 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json': The repository primary signature validity period has expired. [D:\workspace\_work\1\s\src\NuGet\Microsoft.Net.Compilers.Toolset\Microsoft.Net.Compilers.Toolset.Package.csproj]

@Youssef1313 Youssef1313 reopened this May 23, 2021
@CyrusNajmabadi CyrusNajmabadi merged commit 1f1f977 into dotnet:main May 25, 2021
@ghost ghost added this to the Next milestone May 25, 2021
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 25, 2021
@Youssef1313 Youssef1313 deleted the patch-21 branch May 25, 2021 04:51
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.0.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssef1313 @CyrusNajmabadi @RikkiGibson @jinujoseph