Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.0-preview1-vs-deps to main-vs-deps #53681

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.0-preview1-vs-deps into main-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps
git reset --hard upstream/main-vs-deps
git merge upstream/release/dev17.0-preview1-vs-deps
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps --force

genlu and others added 2 commits May 25, 2021 10:32
Microsoft.Net.PackageGroup.4.8.Redist is being pulled in by VS core workload, so this deopendecy is no longer required.
Remove Compiler's dependency on net472 package
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@Cosifne Cosifne merged commit aaf78ca into main-vs-deps May 26, 2021
@ghost ghost added this to the Next milestone May 26, 2021
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 03:02
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 06:03
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 09:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 09:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 12:02
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 12:02
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 15:06
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 15:06
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 18:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 18:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 21:28
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 26, 2021 21:28
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 00:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 03:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 06:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 09:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 09:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 12:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 15:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 15:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 18:01
@dotnet-bot dotnet-bot restored the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 21:01
@dotnet-bot dotnet-bot deleted the merges/release/dev17.0-preview1-vs-deps-to-main-vs-deps branch May 27, 2021 21:01
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants