Don't validate workspace invariants in release builds #53723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
May 27, 2021
Youssef1313
reviewed
May 27, 2021
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
This method appears in some performance traces when you have lots of workspace operations being done. The validations are useful but mostly would catch an error early during development, so there's no reason to run these except in DEBUG.
jasonmalinowski
force-pushed
the
check-invariants-in-debug-only
branch
from
ae4ea26
to
1f902ca
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method appears in some performance traces when you have lots of workspace operations being done. The validations are useful but mostly would catch an error early during development, so there's no reason to run these except in DEBUG.